https://bugzilla.redhat.com/show_bug.cgi?id=993324



--- Comment #6 from Jonathan De Wachter <[email protected]> ---
> Why the triple '0'? Why not a single '0'?

I thought explicit would be better than implicit, that's now fixed :)


> I don't think this is a good version for release, if you don't have a stable 
> release, I don't think it's time to package it.

Actually, this came from a need to package SFGUI (http://sfgui.sfml-dev.de/)
which has external dependencies.


Anyways, thank you for reviewing my package :) Here's the changes I made...

- Fixed the versioning schemes.
- Fixed version to contain a single 0.
- Added a comment to clarify the absence of "BuildArch: noarch"
- It now uses the Fedora's compiler flags.
- Fixed the license
- Moved make command to %check section
- Fixed release tag
- Fixed summary

... and its new URLs:

New koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5786446
New Spec URL: http://sonkun.fedorapeople.org/ELL/ell.spec
New SRPM URL: http://sonkun.fedorapeople.org/ELL/ell-0-0.1.20130617svn.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=QJERHBjlRw&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to