https://bugzilla.redhat.com/show_bug.cgi?id=995025



--- Comment #2 from Stanislav Ochotnicky <[email protected]> ---
Package looks OK for the most part. Licensing is good (there are a few files
under different licenses but they don't get into binary RPM so BSD is correct). 

Perhaps the only suggestion I have now before starting full-scale review: It
might be nice to package tools/*rnc as samples and tools/*vim as vim plugin.

Vim plugin would require patching as it uses /usr/local directory for default
configuration lookup and wouldn't work since we have no default configuration
shipped. On the other hand shipping and installing that arx.conf into /etc
might make sense. And then let vim plugin use that (it would be possible to
override with a variable though...so maybe something that could be added and
provided upstream)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xxNRUCWUDr&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to