https://bugzilla.redhat.com/show_bug.cgi?id=995974
--- Comment #10 from Michael Schwendt <[email protected]> --- Drive-by comments... > %build > ./autogen.sh Check out the contents of that tiny script. Prefer using autoreconf directly, so you can skip the duplicate and wrong configure invocation. > %package devel > BuildArch: noarch Making it "noarch" is a fundamental packaging mistake, since it's a compiled arch-specific library, and %_libdir is not /usr/lib for some target platforms. > %package python > Requires: %{name}%{?_isa} = %{version}-%{release} python >= 2.7 Easy to miss when multiple deps are on one line. There's an automatic dependency for python(abi) already. The explicit one on "python >= 2.7" is wrong. http://fedoraproject.org/wiki/Packaging:Python > %{_libdir}/pkgconfig/%{name}-1.0.pc It contains a hardcoded libdir=${exec_prefix}/lib which is wrong for build targets where %_libdir is not /usr/lib but /usr/lib64. > $ ls tests > binary test-bson-clock.c test-bson-oid.c > test-bson-writer.c > bson-tests.h test-bson-error.c test-bson-reader.c test_cbson.py > Makefile.include test-bson-iter.c test-bson-string.c > test-bson.c test-bson-json.c test-bson-utf8.c Is this suitable for a %check section? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qXzu07eGPr&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
