https://bugzilla.redhat.com/show_bug.cgi?id=984175
--- Comment #9 from Susi Lehtola <[email protected]> --- (In reply to Volker Fröhlich from comment #8) > I suppose that's desktop-file-validate. It's at the bottom of the build > output. Right. Still, this is not a problem; it's something we want. > > > The qmake macro doesn't seem to work in F18, if you mind. > > > > You probably don't have qt4-devel installed, which is a BR. > > rpmbuild doesn't let you build without BRs installed. Then your system is otherwise broken. I have had no problems with the macro on any releases since around F14 IIRC. > > > What's the upstream status of the patches? > > > http://fedoraproject.org/wiki/Packaging: > > > Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment > > > > All the patches (except 0) are essentially upstream. > > Add URIs or comments then! This is a SHOULD item, not a MUST. The patches already have comments on what they do, and have also version info. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kOfEOJCTwO&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
