https://bugzilla.redhat.com/show_bug.cgi?id=989359



--- Comment #1 from Christopher Meng <[email protected]> ---
- Remove %defattr(-,root,root,-)

- %_datadir --> %{_datadir}

- Remove commented lines.

- cp -a --> cp -pa

- %_datadir/gimp/2.0/brushes/GPS-Brushes/* and such lines in %files:

seems you forgot to own the dir itself, change to:

%{_datadir}/gimp/2.0/brushes/GPS-Brushes/

- %description not good, suggesstion:

GIMP Paint Studio(GPS) is a collection of brushes and accompanying tool
presets. Tool presets are a simply saved tool options, highly useful feature of
the GIMP. The goal of GPS is to provide an adequate working environment for
graphic designers and artists to begin to paint and feel comfortable with GIMP
from their first use.

- I see the %{url} is:

http://gps-gimp-paint-studio.googlecode.com/files/GPS 2_0 final.zip

should use %20 to replace the space " ". But not sure if this is my browser's
problem.

- Please check if CCPL things are included.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DrqCsIaMPn&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to