https://bugzilla.redhat.com/show_bug.cgi?id=924675
Yaniv Bronhaim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Yaniv Bronhaim <[email protected]> --- Hey, did an informal review and found the following issues: 1. the link http://enslaver.fedorapeople.org/project/epoptes/epoptes-0.5.6-1.20130322.05.fc18.src.rpm - doesn't work 2. use %{name} instead of hard-coded "epoptes" 3. python-devel is *depreciated* - please use BuildRequires: python2-devel or BuildRequires: python3-devel 4. %defattr(-, root, root) and %clean session is only required for epel5 -> are you sure that you need it? 5. please use %doc macro for documentation -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eBRgWXUrw5&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
