https://bugzilla.redhat.com/show_bug.cgi?id=963903
Ralf Corsepius <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Ralf Corsepius <[email protected]> --- Sorry, for this review having taken so long, but I simply had forgotten about it. Nothing much to say about it: APPROVED Two minor issues: 1) Redundant "Requires:" # rpm -q --requires -p perl-Net-INET6Glue-0.5-2.fc18.noarch.rpm ... perl(IO::Socket::INET6) perl(IO::Socket::INET6) >= 2.54 ... The first R: perl(IO::Socket::INET6) is redundant to the second one. Consider to filter the first one from inside of the spec rsp. to remove the versioned one from the spec. 2) Consider to add these perl-modules to "BR:" perl(Carp) perl(IO::Socket::INET) perl(IO::Socket::INET6) perl(Net::FTP) perl(Socket) perl(strict) perl(warnings) Other reviewers would insist on them, I don't. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cbXgaAx5Ts&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
