https://bugzilla.redhat.com/show_bug.cgi?id=988938
--- Comment #3 from Axilleas Pipinellis <[email protected]> --- (In reply to Lukas Bezdicka from comment #2) > Issues: > ======= > - gems should require rubygems package > Note: Requires: rubygems missing in rubygem-orm_adapter-doc > See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems False positive. It does require rubygems. > - Package contains Requires: ruby(abi). > See: http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_ABI False positive. Does not contain ruby(abi). > - I don't see reason to have -doc package for README. This should be all in > one. In -doc there are also, History.txt, Gemfile, Rakefile and tests. > I also think that Rakefile and Gemspec aren't doc, are they? You are right, they are not directly documentation, as the doc subpackage suggests, but I thought it would be ok to include these in case they would seem useful to someone. I excluded them. Those two below are false positives. > Ruby: > [!]: Specfile should use macros from rubygem-devel package. > Note: The specfile doesn't use these macros: %exclude %{gem_cache}, > %{gem_spec}, %{gem_libdir} Macros are included. > [!]: Test suite of the library should be run. Test suite is running. SPEC: http://axilleas.fedorapeople.org/pkgs/rubygem-orm_adapter/rubygem-orm_adapter.spec SRPM: http://axilleas.fedorapeople.org/pkgs/rubygem-orm_adapter/rubygem-orm_adapter-0.4.0-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1uIotP0217&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
