https://bugzilla.redhat.com/show_bug.cgi?id=1002321

Christopher Meng <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[email protected] |
                   |project.org                 |
                 CC|                            |[email protected]



--- Comment #1 from Christopher Meng <[email protected]> ---
Woo...

Double check:

License:        (GPL+ or Artistic) and (GPLv2+ or Artistic) and MIT and Public
Domain and UCD


========================

1. Remove these:

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

rm -rf $RPM_BUILD_ROOT

find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;


%clean
rm -rf $RPM_BUILD_ROOT

%defattr(-,root,root,-)

2. "%{__perl}" can just be "perl"

PERL_INSTALL_ROOT can be DESTDIR

3. What's this?

* Wed Aug 28 2013 = Matias Kreder <[email protected]> 2.03-1

"="?

4. You can drop the explicit version requires.

5. Package %description is not good.

Suggestion copied from CPAN:

File::KeePass gives access to KeePass version 1 (kdb) and version 2 (kdbx)
databases.

The version 1 and version 2 databases are very different in construction, but
the majority of information overlaps and many algorithms are similar.
File::KeePass attempts to iron out as many of the differences.

File::KeePass gives nearly raw data access. There are a few utility methods for
manipulating groups and entries. More advanced manipulation can easily be
layered on top by other modules.

File::KeePass is only used for reading and writing databases and for keeping
passwords scrambled while in memory. Programs dealing with UI or using of
auto-type features are the domain of other modules on CPAN.
File::KeePass::Agent is one example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xgieerGlvH&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to