https://bugzilla.redhat.com/show_bug.cgi?id=821406
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from Christopher Meng <[email protected]> --- 1. 2.2.9 is released. 2. Where is zlib-devel/pcre-devel/libattr-devel/libcanberra-gtk3/xmlrpc-c-c++/miniupnpc-devel? 3. qt-devel >= 4.6.0 should be qt4-devel 4. %description qt Qt-based graphical interface %description gtk Gtk interface based on code of FreeDC++ and LinuxDC++ Missing dot "." . 5. rm -rf %{buildroot}/usr/share/%{name}/examples/*.php desktop-file-validate %{buildroot}/%{_datadir}/applications/*qt*.desktop Why don't you use macro? And, %{buildroot}/%{_datadir} should be %{buildroot}%{_datadir} as %{_datadir} eq /usr/share, already has the slash. 6. Requires: %{name}-gui = %{version}-%{release} Auh, shouldn't it be Requires: %{name}-gui%{?_isa} = %{version}-%{release}? 7. Since gtk/qt subpackage requires main package, I think you can ship doc once. So remove the %doc AUTHORS COPYING in 2 subpackages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QZYCgXXXam&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
