https://bugzilla.redhat.com/show_bug.cgi?id=951827
Luya Tshimbalanga <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Luya Tshimbalanga <[email protected]> --- Hello Elad, Quick review: - remove rm -fr %{buildroot} within #install - %clean section is not required in F13 and above according to https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean - Why BuildRequires: dos2unix? multilingual - Why including OFL-license.txt in %build section? - rpmlint generated two warnings: alef-fonts.noarch: W: spelling-error Summary(en_US) multi -> mulch, mufti alef-fonts.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti Both Summary and %description should use US English: multi-lingual should be multilingual. - Add %_font_pkg -f %{fontconf} *.ttf after this line ln -s %{_fontconfig_templatedir}/%{fontconf} \ %{buildroot}%{_fontconfig_confdir}/%{fontconf} -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S8uK3AUjK7&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
