https://bugzilla.redhat.com/show_bug.cgi?id=1000970
Michael Schwendt <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|[email protected] | |project.org | --- Comment #5 from Michael Schwendt <[email protected]> --- No full review, just drive-by comments: > License: GPLv2+ Please verify. Consulting the help of the fedora-review tool may be an idea. File COPYING is GPLv3. README says "Released under GPLv3 terms". Several Python source files say GPLv3 "or later". > Requires(post): systemd Systemd's RPM macros are included in the systemd package, so "BuildRequires: systemd" will be needed. > LC_ALL=en_US.UTF-8 make install DESTDIR=%{buildroot} > > %ifarch x86_64 > mkdir -p %{buildroot}%{_libdir} > mv %{buildroot}%{_prefix}/lib/pm-utils %{buildroot}%{_libdir}/pm-utils > %endif x86_64 is not the only arch where %_libdir is /usr/lib64. The package would fail to build for those archs. Here it failed even for F19 and Rawhide, but with %find_lang not finding anything. Has it been tested/built at all? > Can I put files to /usr/lib/pm-utils on x86_64? If you look up pm-utils.x86_64 at koji or its spec file, http://pkgs.fedoraproject.org/cgit/pm-utils.git/plain/pm-utils.spec what do you find? > %{_datadir}/applications/%{name}-preferences.desktop https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage > %exclude %{_sysconfdir}/xdg/autostart/%{name}-session-service.desktop There is no comment here? Why is the file excluded? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pV4DKV7zH4&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
