https://bugzilla.redhat.com/show_bug.cgi?id=783016
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(itamar@ispbrasil. | |com.br) --- Comment #14 from Christopher Meng <[email protected]> --- 1. I hope you can koji build --scratch rawhide SRPM to test if it can be built on rawhide since you're using f17(EOL) to build this package. 2. And, as far as I can see, Itamar has been busy for a long time, so lifting needinfo again, if still no response here I will help reset the assignee. 3. Are you going to support EL5/6? (This will help me tell your errors in your spec) 4. BuildRequires: python2-devel,pygame,PyQt4,pybox2d Requires: pygame,PyQt4,pybox2d Please double check "pygame,PyQt4,pybox2d" are needed or not during Building. ALSO missing BR python-setuptools. 5. I just visited github page and found LGPLv3(se distribuye bajo la licencia LGPLv3.) 6. manualmente en tu equipo con el siguiente comando: nosetests as test, so I think you can enable %check and add BR python-nose to test it. But you've removed them by rm -rf tests, reason? 7. No need to ship PKG-INFO 8. %dir %{python_sitelib}/pilas/ %{python_sitelib}/* can be %{python_sitelib}/pilas/ Or replace %{python_sitelib}/pilas-%{version}-py%{pyver}.egg-info %dir %{python_sitelib}/pilas/ %{python_sitelib}/* with %{python_sitelib}/* only. 8. %description is too short, please translate more. 9. %setup -q -n pilas-%{version} can be %setup -q as this is the default. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PY0nKqCICX&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
