https://bugzilla.redhat.com/show_bug.cgi?id=1005173
Jon Ciesla <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #1 from Jon Ciesla <[email protected]> --- Good: - rpmlint checks return: SDL2_image.x86_64: W: no-manual-page-for-binary showimage Each executable in standard binary directories should have a man page. None exists. SDL2_image-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files Move README.txt into -devel - package meets naming guidelines - package meets packaging guidelines - license ( LGPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Otherwise very clean. Move the README prior to import. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DGQQhAFmKo&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
