https://bugzilla.redhat.com/show_bug.cgi?id=1005172

Christopher Meng <cicku...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Christopher Meng <cicku...@gmail.com> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
  or number of files.
  Note: Documentation size is 2416640 bytes in 171 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


Rpmlint
-------
Checking: python-llvmpy-0.12.0-1.fc20.i686.rpm
          python-llvmpy-0.12.0-1.fc20.src.rpm
python-llvmpy.src: W: spelling-error %description -l en_US llvm -> llama
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

--> Ignorable


Provides
--------
python-llvmpy:
    python-llvmpy
    python-llvmpy(x86-32)



Unversioned so-files
--------------------
python-llvmpy: /usr/lib/python2.7/site-packages/llvmpy/_api.so
python-llvmpy: /usr/lib/python2.7/site-packages/llvmpy/_capsule.so

--> Ignorable


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -rvn python-llvmpy-0.12.0-1.fc19.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Python, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

***************************************
APPROVED.

Suggestions:

1. %{buildroot}/%{python_sitearch} can be %{buildroot}%{python_sitearch}

2. Source can be Source0

3. Is it possible to use llvmpy as its %{name}? I think upstream won't release
2 version for py2 and py3 in parallel.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cwLJ439IDX&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to