https://bugzilla.redhat.com/show_bug.cgi?id=1001028
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|[email protected] | |project.org | --- Comment #3 from Christopher Meng <[email protected]> --- (In reply to Dhiru Kholia from comment #1) > I have some *informal* review comments, > > - %{__python} is deprecated, please use %{__python2} (see: > https://fedoraproject.org/wiki/Packaging:Python#Macros) Yep, thanks. I just got it from the list. > - Upstream releases don't include a separate LICENSE file. Can you please > contact upstream about fixing this? Ah, they have added a LICENSE file on github, I will check again(maybe I forgot to add it as %doc, or maybe caused by no such file, will check when possible.) Thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mUCLKWBOnF&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
