https://bugzilla.redhat.com/show_bug.cgi?id=995995



--- Comment #5 from Michael Schwendt <[email protected]> ---
Have rpmlint and/or "fedora-review -b 995995" been run for this one yet?


> %files data
> %dir %{_datadir}/liblunar
> %{_datadir}/liblunar/*

  %files data
  %{_datadir}/liblunar/

would be shorter and achieves the same. 

Btw, here the subpackage includes only three tiny files, each below 1KB, and
the base package even strictly depends on this package. Is that really enough
reason to introduce a noarch subpackage?


> %package        docs

The guidelines recommend -doc not -docs:
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

The subpackage is 14788 bytes long. I would keep it in the -devel package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=j2rFta1kZd&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to