https://bugzilla.redhat.com/show_bug.cgi?id=1006197
--- Comment #2 from Michael Schwendt <[email protected]> --- * Run rpmlint (or rpmlint -i for more helpful output) on the src.rpm and all built rpms. Feel free to ignore obvious false positives in the report, but fix anything else. Preferably add a comment here about whether/when you think what rpmlint reports is correct or incorrect. > %setup -q -n %{upstream_name}-%{upstream_short_name}_%{version} > > unzip %{SOURCE1} %setup can unzip, too. You don't need a second line for that. Use: %setup -q -a 1 -n %{upstream_name}-%{upstream_short_name}_%{version} > 2. %{_var} should be %{_localstatedir} Giving a rationale/explanation would be more helpful. We don't use macros just for fun. Nothing during the build uses %{_localstatedir}. The %configure macro isn't used either (it would pass --localstatedir=/var to the build framework). So, using %{_var} is fine, but only provided that you use it consistently. The sed substitution uses a hardcoded /var, so I would either use /var or %{_var} everywhere, but not mix them. > %build That section currenly only supports a few architectures and doesn't call make for unknown archs. ExclusiveArch or ExcludeArch usage is missing: https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support > install -m 644 Book.bin $RPM_BUILD_ROOT%{_var}/lib/games/%{name} To be verified. Is that path correct? The Polyglot .ini file contains a /usr/share/games/stockfish/Book.bin path. Also consider contacting the Fedora Games SIG, since they tell that runtime configuration files should go in /var/games/%{name} instead. http://fedoraproject.org/wiki/SIGs/Games -> http://fedoraproject.org/wiki/SIGs/Games/Packaging -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KetZj0EXIj&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
