https://bugzilla.redhat.com/show_bug.cgi?id=979166
Matthias Kuhn <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Matthias Kuhn <[email protected]> --- General: 1. The help files should not go into %{_libdir}. 2. The Summary and %description focuses very much on Oracle, while the appropriate BuildRequires are commented out. The resulting binary and the summary/description should match. 3. I would recommend maintaining the .desktop file as a separate source file. Running rpmlint -i on the resulting .rpm: 1. There is an incorrect free software foundation address in the README file. Upstream should be informed. http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address 2. There are only non binary files in /usr/lib so they should be in /usr/share (see helpfile comment above) 3. /usr/share/doc/tora-3/NEWS: The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). 4. Binary tora: Each executable in standard binary directories should have a man page. Running rpmlint -i on the .src.rpm: 1. There are some bogus dates in the changelog. Disclaimer: I'm not an approved fedora packager, so this review is probably not perfect at all. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9NmaUYHhwo&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
