https://bugzilla.redhat.com/show_bug.cgi?id=1008063
--- Comment #2 from Trond H. Amundsen <[email protected]> --- Hello Henrik, This isn't an official review. I've just taken a look and have a couple of comments. * You should specify man pages in the %files section as glob patterns such as "%{_mandir}/man1/ag.1*", to avoid errors when/if we change the man page compression sometime in the future * The binary RPM has a conflict: /usr/bin/ag is already provided by the package python-ase (I've only checked on f19) * The package name concerns me. I don't think underscores in package name is strictly disallowed, but it's frowned upon and should be avoided. -trond -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2UaEv21COr&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
