https://bugzilla.redhat.com/show_bug.cgi?id=1011500

Lubomir Rintel <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[email protected] |
                   |project.org                 |



--- Comment #2 from Lubomir Rintel <[email protected]> ---
(In reply to Christopher Meng from comment #1)
> BuildRequires:  pkgconfig(dconf)
> 
> can be dconf-devel, no need to use pkgconfig everywhere.

config.tests/dconf/dconf.pro seems to use pkgconfig to locate the package.
This is more robust.

> Use github tag

I do (v0.1.0) and am not sure I understand what you really mean.

> No license as %doc

Will fix.

> Why
> 
> BuildRequires:  qt5-qtbase-devel >= %{version} ??

The version? I copied it from another qt5 package.
I'll remove that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vEgK28RxBg&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to