https://bugzilla.redhat.com/show_bug.cgi?id=1012391
Terje Røsten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|[email protected] | |project.org | CC| |[email protected] --- Comment #3 from Terje Røsten <[email protected]> --- > SPEC: http://kupo.se/pub/makepasswd/makepasswd-2.spec Don't version the file name, use makepasswd.spec always. > Source0: > http://people.defora.org/~khorben/projects/makepasswd/%{name}-%{version}.tar.gz You can drop %{name} macro, the important thing is %{version} > Patch0: db2man.sh.diff Indent correctly > BuildRequires: docbook-style-xsl libxslt Use only one buildreq per line. > %description > Makepasswd generates (pseudo-)random passwords of a desired length. > It is available under the GPL version 3. License info not needed in %description > cd doc I prefer pushd doc > # make install DESTDIR=$RPM_BUILD_ROOT/usr/bin Remove. > %{_mandir}/man1/makepasswd.1.gz Drop .gz, just use %{_mandir}/man1/makepasswd.1* (conpression from rpmbuild might change). Any license files in %files? Use %doc macro. %changelog * Mon Sep 26 2013 Johan Swensson <[email protected]> 0.5.1-2 - package fixes with input from informal review Insert empty line here. * Mon Sep 26 2013 Johan Swensson <[email protected]> 0.5.1-1 - initial build > Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5986644 From build log: cc -W -Wall -g -O2 -pedantic -c makepasswd.c cc -W -Wall -g -O2 -pedantic -c md5c.c cc -o makepasswd makepasswd.o md5c.o -lcrypt Correct build flags is not used, please fix. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e2mI7seD3q&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
