https://bugzilla.redhat.com/show_bug.cgi?id=1019437
Antonio Trande <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from Antonio Trande <[email protected]> --- > >(In reply to Lubomir Rintel from comment #7) > > No. That serves no purpose, harms readability and is not required by the > > guidelines. > (In reply to Mario Blättermann from comment #8) > Indeed, we are not forced to use macros in this case. The main meaning of > consistency is to don't mix shell variables and macros with the same value, > for example $RPM_BUILD_ROOT and %{buildroot}. > In some cases reviewers even are a bit piqued if they read URLs containing > macros, so that they cannot copy and paste them. No problem for me, I run > rpmlint, and I get proper and macro-free links. Okay. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
