https://bugzilla.redhat.com/show_bug.cgi?id=1020681
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Christopher Meng <[email protected]> --- Drop-by ideas: 1. Requires: perl-DBD-Pg Have you tried Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) If RPM still can't find perl-DBD-Pg, you should add it. However, I would have question about Requires: perl-DBD-Pg Since Fedora never suggests this way but this: perl(DBD::Pg). 2. Better add a comment at %build so we know nothing is going to be built. 3. %description PgToolkit is a collection of tools for PostgreSQL maintenance. PgToolkit so far uses the utility pgcompact to reduce PostgreSQL table and index bloat from databases. Too long, longer than 79 chars limitation, please change. 4. cp -drv lib/PgToolkit/ %{buildroot}%{perl_archlib} --> cp -adrv lib/PgToolkit/ %{buildroot}%{perl_archlib} 5. I would just write: %{perl_archlib}/PgToolkit to replace tons of lines in %files. BTW I think %{perl_archlib} is wrong for noarch packages. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
