https://bugzilla.redhat.com/show_bug.cgi?id=1018492
--- Comment #10 from Dridi Boukelmoune <[email protected]> --- (In reply to Ankur Sinha (FranciscoD) from comment #9) > Nitpicks: > - Please comment the patch, and send it upstream too. I will, I have another ongoing issue (RFE) with uptream, I will send a pull request before commiting to the SCM (and add a comment). > - Since you're installing to pkgdocdir, and the %doc macro already takes > ownership of it, you don't need to specify it again. From > http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_prefixes: > "Usually, "%doc" is used to list documentation files within %{_builddir} > that were not copied to %{buildroot}. A README and INSTALL file is usually > included. They will be placed in an appropriate directory under > /usr/share/doc, whose ownership does not need to be declared. " Some files are installed with the %doc macro (LICENSE CONTRIBUTORS changelog) and the others with `make install'. There shouldn't be any dupe in the %files section. > Not blockers though. You can fix them up before you commit to SCM. > > +++ APPROVED +++ > Thanks, > Warm regards, > Ankur Thank you for the review, Dridi -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
