https://bugzilla.redhat.com/show_bug.cgi?id=1021719
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Christopher Meng <[email protected]> --- 1. Remove Buildroot/%{__rm} -rf %{buildroot}/%clean 2. RPM can handle paths well, you should use make but not %{__make} now, same like %{__rm}/%{__mv}/%{__ln_s} 3. Ship %doc INSTALL is useless IMO. 4. %{_mandir}/man5/*.5.gz %{_mandir}/man8/*.8.gz --> %{_mandir}/man5/*.5* %{_mandir}/man8/*.8* 5. Requires(pre): %{_sbindir}/groupadd Requires(pre): %{_sbindir}/useradd --> Requires(pre): shadow-utils 6. Only a few packages still ship sysv scripts http://pkgs.org/search/?keyword=-sysvinit&search_on=name&distro=80 Do we really need it? 7. [rpmaker@fab SPECS]$ rpm -E %_localstatedir /var 8. install with -p option to preserve timestamp. 9. Do we need a systemd socket file like: [Unit] Description=OpenSMTPD Socket [Socket] ListenStream=/var/run/smtpd.sock [Install] WantedBy=sockets.target 10. Do we need to set conflicts with other packages in systemd service file like http://pkgs.fedoraproject.org/cgit/postfix.git/tree/postfix.service ? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
