https://bugzilla.redhat.com/show_bug.cgi?id=1022407
Ralf Corsepius <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Ralf Corsepius <[email protected]> --- Just some remarks based on very brief checks on F19 (It's unlikely I'll be formally reviewing this, because my knowledge on python is fairly limited): MUSTFIX: * warning: File listed twice: /usr/share/dbus-1/services/org.baseurl.YumSession.service warning: File listed twice: /usr/share/dbus-1/system-services/org.baseurl.YumSystem.service warning: File listed twice: /usr/share/polkit-1/actions warning: File listed twice: /usr/share/polkit-1/actions/org.baseurl.YumSystem.policy * Unowned directories: /usr/lib/python3.3/site-packages/yumdaemon/ /usr/lib/python2.7/site-packages/yumdaemon/ SHOULD: * rm -rf $RPM_BUILD_ROOT in %install You don't seem to support EPEL, so this line doesn't make much sense. * %files contains %{_datadir}/* This is too general at least for my taste UPSTREAM CONSIDER: The package does not honor/receive any configuration input parameters (e.g. installation paths) - I'd recommend upstream to change this. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
