https://bugzilla.redhat.com/show_bug.cgi?id=1020839
--- Comment #16 from Michael Schwendt <[email protected]> --- File at "Spec URL" differs from spec file in src.rpm at "SRPM URL". The %doc line is different. If you kept those two lines in the review ticket up-to-date, it would become convenient to run "fedora-review -b 1020839" and let that tool perform some packaging checks. > Summary: GUI tool for adding karma to Bodhi system. > Similar to fedora-easy-karma What I find surprising here is that the %summary uses two terms not used in the %description: karma, Bodhi I would drop the insider talk and write: Summary: GUI for sending feedback about installed Test Update packages The %description could expand on that and mention the "Fedora Updates System" (bodhi), explain that users/testers can vote about test-updates using "karma" points. If you consider it relevant, you could mention the CLI tool fedora-easy-karma in the description, but I think they are different enough. And in a related search, fedora-easy-karma ought to turn up as well. > desktop-file-install > desktop-file-validate Using either one is sufficient. desktop-file-install also validates the specified file. > desktop-file-install \ > --dir=%{buildroot}%{_datadir}/applications \ > %{buildroot}/%{_datadir}/applications/fedora-gooey-karma.desktop What this does is it reinstalls (!) and validates the existing desktop file found at the path inside the %buildroot. But if the desktop file is located in the %buildroot already, you only need to validate it. Hence I suggest you only run desktop-file-validate and not desktop-file-install. Using the latter makes more sense if you need to install the file actually, or if you want to use the tool's options to modify the .desktop file on-the-fly. Files that are not supposed to be executed should not be mode +x: -rwxr-xr-x /usr/share/fedora-gooey-karma/bodhiworker.py -rwxr-xr-x /usr/share/fedora-gooey-karma/browser.py -rwxr-xr-x /usr/share/fedora-gooey-karma/config.py -rwxr-xr-x /usr/share/fedora-gooey-karma/customgui.py -rwxr-xr-x /usr/share/fedora-gooey-karma/idlequeue.py -rwxr-xr-x /usr/share/fedora-gooey-karma/idlequeuedispatcher.py -rwxr-xr-x /usr/share/fedora-gooey-karma/packagesworker.py -rwxr-xr-x /usr/share/fedora-gooey-karma/sendkarma.py -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
