https://bugzilla.redhat.com/show_bug.cgi?id=821917
Michael Schwendt <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #17 from Michael Schwendt <[email protected]> --- * "fedora-review -b 821917" fails due to a build failure. Give it a try. * Manual rpmbuild on Fedora 20 development also fails: checking for xapian-config... xapian-config configure: error: *** xapian version >= 1.2 needed, but version 1.2.15 found. > make %{?_smp_mflags} Build output is non-verbose. Figure out whether can configure with --disable-silent-rules, whether running "V=1 make …" works, or whether patching the Makefiles may be needed. Only then it would become possible to see the used compiler/link flags and options and e.g. verify them. > %install > rm -rf %{buildroot} Buildroot is created and emptied automatically nowadays, so preferably be explicit about whether the spec file is supposed to target EL5: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > %defattr(-,root,root,-) is not needed anymore for any of the active dists (even EL5): https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > %{_datadir}/man/man*/*.gz %{_datadir}/man/man*/* is what many reviewers recommend, because it allows for changed/customised/disabled compression of manual pages. * Without being able to build the package, I can only point out that I find its inter-dependencies too complicated: emacs-mu4e-el requires emacs-mu4e, which in turn requires emacs(bin) and mu but emacs-mu4e-el additionally requires emacs and mu so the dependency on "emacs" and "mu" is redundant, and since I wondered why splitting of the source files into a separate subpackage would be justified, I've searched a bit in the packaging guidelines: https://fedoraproject.org/wiki/Packaging:Emacs#Packaging_of_source_elisp_files That part of the guidelines explains several scenarios. Splitting of -el subpackages for the source files has been done only up to Fedora 16. It's even possible to include the files in the base "mu" package with a proper dep on emacs-filesystem. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
