https://bugzilla.redhat.com/show_bug.cgi?id=1024152



--- Comment #2 from Mamoru TASAKA <[email protected]> ---
Well, I tried checking your srpm and the rebuilt binary rpms
carefully, and I did not find any blockers for this package.

One recommendation
* Separated license text
  - I recommend to rename "LICENSE" to something unique to this srpm,
    like "LICENSE.innertube", then again rename when building this srpm,
    in case some other srpm also has a
    file "LICENSE" and this file may overwritten when srpms are
    expanded (on ~/rpmbuild/SOURCES/, for example)

 - spec / srpm clean
 - builds file
 - can be installed cleanly
 - seems to work

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to