https://bugzilla.redhat.com/show_bug.cgi?id=1026052
Ken Dreyer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #3 from Ken Dreyer <[email protected]> --- I'll need this for rubygem-github-markup, so I can take this review. Most importantly: Can you please add the test suite in %check? Please use HTTPS for the URL and Source0. Do you need to have the version number comparison (">= 1.3.6") for rubygems and rubygems-devel? If not, I recommend leaving it out. Does this package need rubygem(rubyforge) and rubygem(rake)? I'm thinking these can be removed from the Requires/BuildRequires. Is this chmod line necessary? chmod 0644 %{buildroot}%{gemdir}/cache/*gem Are you planning on building for EL5? If not, please remove the %defattr(-, root, root, -) lines under %files. You're using the old-style EL6 macros, like gemdir or geminstdir. Can you switch this to use the newer styles available in F19? The gem2rpm tool that's available in Fedora 19 should help you. If you're still interested in packaging this for EL6, you can just use backwards-compatible macros. My suggestion would be to re-run gem2rpm on Fedora 19 for this gem. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
