https://bugzilla.redhat.com/show_bug.cgi?id=1000870
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- 1. Package is noarch, so the -devel should not require %{name}%{?_isa}, just plain %{name}. 2. %description should be a bit more informative about what the library does, and should not repeat the blurb "uncommonly powerful" which doesn't really mean much. 3. The contents of the "Docs" directory could be moved one level up (so there would be /usr/share/doc/nini/Reference/, /usr/share/doc/nini/Manual). - License is OK - package name is OK - spec is nice and clear - sources are downloadable and match the srpm - dist tag is there - no build root or other obsolete stuff - license is ok, file present and installed - latest version - follows Mono guidelines - %files is OK rpmlint nini: nini.src:37: E: hardcoded-library-path in %{_prefix}/lib/nini nini.src:39: E: hardcoded-library-path in %{_prefix}/lib/nini/ nini.src:46: E: hardcoded-library-path in %{_prefix}/lib/nini/ It's OK per mono guidelines. nini.src:41: W: macro-in-comment %{name} nini.src:41: W: macro-in-comment %{buildroot} nini.src:41: W: macro-in-comment %{_prefix} That comment could be removed. nini.src: W: invalid-url Source0: http://downloads.sourceforge.net/project/nini/Nini/1.1.0/Nini-1.1.0.zip timed out Works for me. % rpmlint nini-devel nini-devel.noarch: W: no-documentation nini-devel.noarch: W: spurious-executable-perm /usr/share/pkgconfig/nini.pc ${SOURCE1} should be -x. Nice and clean module issues noted above. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
