https://bugzilla.redhat.com/show_bug.cgi?id=1028741
David Tardon <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Flags| |needinfo?(anto.trande@gmail | |.com) --- Comment #2 from David Tardon <[email protected]> --- Remarks: * I suggest to use %{version} in Source0. * I do not think it is a good idea to hardcode Fedora compilation * * options through a patch. Why not patch the Makefiles to use "CFLAGS = $(CFLAGS) -D..." (similarly for CXXFLAGS) and then pass CFLAGS="%{optflags}" as an argument to make? ** And I see that you have already solved it that way... So the patches can just be dropped, right? * ## Fix 'src/pointset.cpp' compilation error. sed -i '36a #include <algorithm>' src/digitdoc.cpp sed -i '32a #include <algorithm>' src/pointset.cpp Is upstream avare of this problem? * Is there any reason why you are putting .cpp files to /include (or headers, for that matter? The package does not contain a library.) * You need to add %exclude %{_includedir}/%{name}-%{version}/transpose/ to %files devel. The dir is currently duplicated in -devel and -transpose-devel. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
