Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592628

--- Comment #2 from Rahul Sundaram <[email protected]> 2010-05-29 04:51:39 EDT 
---

You can drop the following:
- python macro definition on top
- Buildroot definition
- no need to clean the buildroot in install section
- clean section

The su patch requires a comment as per

http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

You could run sed in a loop 

License status is unclear.  Source files don't have a proper license
attribution and does not specify the version.  LGPL also requires that you
include a copy of the license along with the source.  Please contact upstream
and ask them to fix these issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to