https://bugzilla.redhat.com/show_bug.cgi?id=1035935



--- Comment #10 from Christopher Meng <[email protected]> ---
1. %{python_sitearch} --> %{python2_sitearch}. MUST.

2. /%{_var}-->%{_localstatedir}.

3. install -D -p -m 755 tools/mirrorprobe-logrotate
%{buildroot}/%{_sysconfdir}/logrotate.d/mirrorprobe

-->

install -pDm644 tools/mirrorprobe-logrotate
%{buildroot}/%{_sysconfdir}/logrotate.d/mirrorprobe

4. %package scanner should add perl magic:

Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))

And then remove redundant requires listed already.

5. better to use which apxs to %global the apxs macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to