https://bugzilla.redhat.com/show_bug.cgi?id=1039138
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Christopher Meng <[email protected]> --- I like this package, it's really useful for me! 1. Release: 0%{?dist} Remember to change it to 1 in SCM ;) 2. Source0: http://key-mon.googlecode.com/files/key-mon-1.16.tar.gz As gcode will shut down the download section from 2014 as well as this is a python package, you can find it in the Package Index(pypi): https://pypi.python.org/pypi/key-mon So please change the Source0 to: https://pypi.python.org/packages/source/k/key-mon/key-mon-%{version}.zip 3. BuildRequires: desktop-file-utils %description Leave a blank line between each other. 4. for lib in %{buildroot}%{python2_sitelib}/keymon/*.py; do sed '1{\@^#!/usr/bin/python@d}' $lib > $lib.new && touch -r $lib $lib.new && mv $lib.new $lib done Well, please do this in %prep, don't do that after %build 5. %doc only has an reStructuredText file of README, please also include COPYING. 6. You should ship manpage also. Also seems it's useless ;) 7. From the homepage, you've missed some Requires: pygtk2 python-xlib librsvg2 8. Patch binary key-mon to %{__python2} as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
