https://bugzilla.redhat.com/show_bug.cgi?id=991621



--- Comment #6 from Will Benton <[email protected]> ---
Thanks for making these changes, Gil.  I've reviewed the code and it appears
that removing the custom serialVersionUID values won't have much impact in this
case (since the generated ones are strictly less descriptive than default
ones).

Please make two more quick changes and then I'll do a final review:

1.  I believe that the license was GPLv2 with linking exception *and* LGPLv2,
but since you've patched out the GPLv2 code, the license is just LGPLv2 now.
2.  Please delete the line that patches COPYING.LIB altogether.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to