https://bugzilla.redhat.com/show_bug.cgi?id=1047599
Remi Collet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Remi Collet <[email protected]> --- I agree. About name: from very recent Guidelines change: "You should generally use lowercase and turn underscores into dashes unless there's a compelling reason to follow a different upstream convention." Something to be fixed in "pear make-rpm-spec..." About: [ -f package2.xml ] || mv package.xml package2.xml mv package2.xml %{pear_name}-%{version}/%{name}.xml Cosmetic: It's usually enough to just use the package.xml (having both package.xml and package2.xml could exists in very old package but is not supported anymore (by PEAR), so usually, just check line <package packagerversion="1.9.2" version="2.0"..) About dependencies, from Guidelines: "PHP extensions must have a Requires on all of the dependent extensions (php-date, php-gd, php-mbstring, ...). " So yes php-date and php-pcre are mandatory (as extensions/packages split have change and will very probably change again) From Guidelines: "Common licenses that require including their texts with all derivative works include ASL 2.0, EPL, BSD and MIT. ", so Yes LICENSE file is mandatory for this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
