https://bugzilla.redhat.com/show_bug.cgi?id=1047478
--- Comment #5 from Remi Collet <[email protected]> --- Damn... I think I have commented this review... probably forget to press the submit button :( Yes, please move the config file to /etc About the "web" part, if someone want it, it will not have to be in the php namespace, as this is not a library (so p.e. "irods" will be a correct name) But I'm fine with current naming (php-irods is ok too) I also think "tutorials" and "utilities" should go in %doc, so the full "prods" tree will be provided (warning: clean the .svn dir). I prefer to see "Fix: wrong-file-end-of-line-encoding" in %prep (and using perl is probably a big hammer when sed is enough) %{dist} => %{?dist} (new fedora-review complains about this, and is right) Even if LICENSE.txt is identical to prods/src/LICENSE.txt, you should rather use the second one, which really apply to prods library. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
