https://bugzilla.redhat.com/show_bug.cgi?id=1046125
Remi Collet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Remi Collet <[email protected]> --- Release: 2%{github_release}%{?dist} I agree have the dot in the constant value is simpler as you will only have to comment the definition when not needed. So you should probably use %{?github_release} ;) [x]: Dist tag is present (not strictly required in GL). [x]: Package does not generate any conflict. Blocker fixed. === APPROVED === -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
