https://bugzilla.redhat.com/show_bug.cgi?id=1048493
Denis Fateyev <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Denis Fateyev <[email protected]> --- Some notes first: 1) Please use %global instead of %define, as recommended in official guidelines; 2) There is something complicated with the license, please clarify it; 3) Don't need to mix macros-style calls with normal calls: for i in 16 22 24 32 36 48 64 72 96 128 256 ; do mkdir -p $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/${i}x${i}/apps ... install -D %{SOURCE1} \ ... ##Define static files location %{__mkdir_p} $RPM_BUILD_ROOT%{icecat_static} --- better to leave only one (normal paths are now preferable); 4) Use "install" with '-p' option to preserve timestamps; 5) "export PREFIX='%{_prefix}'" and "export LIBDIR='%{_libdir}'" - are they really needed? Haven't checked yet, just asking first. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
