https://bugzilla.redhat.com/show_bug.cgi?id=1045556

Haïkel Guémar <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #3 from Haïkel Guémar <[email protected]> ---
Quick review.

Builds on rawhide (F21), it has missing dependencies on F20 and lower (notably:
objectweb-asm3, jamon-maven-plugin) for people who want to try it.


I ran rpmlint (very very long output so i won't put it here) and found:
* 6 errors (script-without-shebang) => it concerns some scripts installed in
/usr/share/hbase/bin, the shell ones are clearly libraries, the ruby ones are
clearly meant to be called through hbase jruby based shell.
Since guidelines doesn't enforce but highly encourage packager using libexecdir
for helper scripts, it's ok for me

hbase.noarch: E: script-without-shebang
/usr/share/hbase/bin/replication/copy_tables_desc.rb
hbase.noarch: E: script-without-shebang /usr/share/hbase/bin/hbase-config.sh
hbase.noarch: E: script-without-shebang /usr/share/hbase/bin/region_mover.rb
hbase.noarch: E: script-without-shebang /usr/share/hbase/bin/hirb.rb
hbase.noarch: E: script-without-shebang /usr/share/hbase/bin/hbase-common.sh
hbase.noarch: E: script-without-shebang /usr/share/hbase/bin/region_status.rb

* 163 warnings: A gazillion of dangling symlinks, i haven't finished reviewing
them all but seems safe. At least, there's no bundled libraries

* packaging looks fine, installs ok but needs to be tested under a rawhide VM

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to