Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569492 Ankur Sinha <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #6 from Ankur Sinha <[email protected]> 2010-06-03 12:46:09 EDT --- hey, a quick look: - use http://fedoraproject.org/wiki/Packaging/Python#Macros for the python macros - You don't need all the defines at the beginning. Please get rid of them? It's just doing it twice :) - no need for unmangled_version, it looks same as version - prefix is not to be defined in a tag - vendor tag is obsolete have a look at https://fedoraproject.org/wiki/A_Short_RPM_Tutorial#A_complete_hello.spec_file for the tags to be used. You should add comments rationalizing the Requires as per https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires - use cflags so the build section would go: %build CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build - similiarly the install section would go %{__python} setup.py install --skip-build Please go through the fedora packaging guidelines at the above mentioned links and then maybe we can do a complete review. regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
