Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592443 Stanislav Ochotnicky <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Stanislav Ochotnicky <[email protected]> 2010-06-04 03:45:57 EDT --- Package seems good, but you could have called desktop-file-install directly with SOURCE2. No need to first install it to RPM_BUILD_ROOT. And please get in touch with upstream and work with them to include readme, release notes etc in the package. While they are at it, they should also have COPYING/LICENSE file there so it's easier to evaluate what is the package license. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
