https://bugzilla.redhat.com/show_bug.cgi?id=1055802

gil cattaneo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from gil cattaneo <[email protected]> ---
some issues:

%install
please remove (unnecessary)
rm -rf %{buildroot}

%package javadoc
please remove (unnecessary)
Group:          Documentation
Summary:        Javadoc for %{name}
please remove (unnecessary)
BuildArch:    noarch

please add LICENSE copy
%files javadoc
%{_javadocdir}/%{name}

please use -p parameter (preserve timestamp)
cp target/%{name}-%{version}.jar %{buildroot}/%{_javadir}/%{name}.jar
cp target/%{name}-%{version}.pom %{buildroot}/%{_mavenpomdir}/JPP-%{name}.pom

suggestion, should better use: install -pm 644

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to