https://bugzilla.redhat.com/show_bug.cgi?id=1056057

Kenjiro Nakayama <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Kenjiro Nakayama <[email protected]> ---
(This is not official review.)

Hi, I am a short comment on your spec file.

I don't know why you wrote the Source0 like this.

> # This URL: https://github.com/01org/dleyna-server/archive/v%{version}.tar.gz
> # will create a dleyna-server-%{version}.tar.gz file
> Source0:        %{name}-%{version}.tar.gz

If you have your code archive on your github, shouldn't you write url like [1]?

[1] https://fedoraproject.org/wiki/Packaging:SourceURL#Github

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to