https://bugzilla.redhat.com/show_bug.cgi?id=970405
František Dvořák <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected], | |[email protected] Flags| |needinfo?([email protected] | |) --- Comment #2 from František Dvořák <[email protected]> --- Steve, do you plan to continue on the work on mingw-speex? It looks like there is no response more than one month and this review can be closed as dead review (http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews). Found issues: (no problem is critical, but 1) and 4) is checked by rpmlint) 1) as mentioned by Veaceslav: Group, %clean, %defattr and 'rm -f' in %install are not needed 2) manual.pdf and manual pages are not needed (already in the native package), NEWS and TODO could be removed too 3) dependencies: - BuildRequire: is MinGW gcc-c++ needed? binutils can be removed ("inherited" by gcc) - Requires: pkgconfig not needed - it is used only on base package, on real mingw32/64 subpackages there should be mingw32/64 version of pkgconfig anyway and it is autogenerated 4) cosmetic: mixed spaces and tabs 5) descriptions could be reformatted/unified 6) cosmetic: combining %exclude (for .la) and 'rm -f' (for manual.pdf) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
