https://bugzilla.redhat.com/show_bug.cgi?id=1047626

Mukundan Ragavan <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Mukundan Ragavan <[email protected]> ---
Hi Adam,

I would like to attempt an **unofficial** review as a part of learning
packaging. So, please excuse me if I say something silly! :)

My comments - 

* spec file Requires: should be moved to before %description. If I build the
rpm as it is now, yum is not pulling in the deps. Moving Requires: seems to fix
that problem.

Running fedora-review produces this - 

Requires
--------
php-google-api-php-client (rpmlib, GLIBC filtered):

which does not list the other dependencies.

Mukundan (nonamedotc)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to