https://bugzilla.redhat.com/show_bug.cgi?id=1054941
--- Comment #2 from Mihkel Vain <[email protected]> --- Spec URL: http://mihkel.fedorapeople.org/SPECS/firefox-esteid.spec SRPM URL: http://mihkel.fedorapeople.org/SRPMS/firefox-esteid-3.8.0.1115-1.fc20.src.rpm Koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=6475735 Hi and thank you for your notes. (In reply to Michael Schwendt from comment #1) > > Summary: EstEID browser plugin for digital signing > > Is the plugin specific to Firefox? Or is only stored in Firefox's plugin > path but based on the old Netscape Plugin API and then would be compatible > with any browser that supports the NPAPI? > > If the summary mentioned Firefox it would be more clear, e.g. > > Summary: Firefox plugin for signing with Estonian ID cards > This plugin is not strictly Firefox specific (as upstream just told me) and it probably works on other NPAPI browsers too, but officially upstream supports only Firefox. > > Requires: opensc > > Requires: pcsc-lite > > Requires: esteidpkcs11loader > > It's good practise to add comments to explicit Requires and explain what > exactly is needed. A dependency on a package name could be broken easily, if > a file moves into a different (sub-)package, for example. > I added some comments best to my knowledge and removed unnecessary dependencies. However I'm not sure how informative my comments are :) > > > %{_libdir}/mozilla/plugins/npesteid-firefox-plugin.so > > Please review the File and Directory Ownership section in the guidelines, > since without a dependency on firefox, there would be "unowned" directories. > https://fedoraproject.org/wiki/Packaging: > Guidelines#File_and_Directory_Ownership I made a requirement on mozilla-filesystem As I said this plugin probably works on other NPAPI supported browsers too, therefore I made it require mozilla-filesystem not firefox. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
