https://bugzilla.redhat.com/show_bug.cgi?id=1060443
--- Comment #2 from Mukundan Ragavan <[email protected]> --- Hi Kevin, Thanks for your comments. > * 1.3 isn't actually out yet. I'd suggest packaging 1.2 until it is... if > there's some compelling reason to do a 1.3 prerelease, you will need to > change the release to handle a prerelease version. See: > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre- > Release_packages Corrected this. I have used 0.1.2 correctly this time. > * I'm not sure the Requires you have are needed. Does it really need > xfce4-session and xfdesktop? I had a strange logic for adding this Requires (this being a package to be used with Xfce). :) Removed the Requires. > * You may want to include some %doc files... ChangeLog, COPYING, and various > others I have added %doc files. I have also included TODO. I cannot find any regulations about that - is it fine to include TODO? New SPEC URL: http://nonamedotc.fedorapeople.org/pkgreview/xfdashboard/xfdashboard.spec New SRPM URL: http://nonamedotc.fedorapeople.org/pkgreview/xfdashboard/xfdashboard-0.1.2-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
